netfilter: ipset: Fix overflow before widen in the bitmap_ip_create() function.
authorGavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Wed, 11 Jan 2023 11:57:39 +0000 (11:57 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 11 Jan 2023 18:18:04 +0000 (19:18 +0100)
commit9ea4b476cea1b7d461d16dda25ca3c7e616e2d15
tree3babdbb5c95bccc098f5f9a8f02df95adaf4fc2a
parentc273289fac370b6488757236cd62cc2cf04830b7
netfilter: ipset: Fix overflow before widen in the bitmap_ip_create() function.

When first_ip is 0, last_ip is 0xFFFFFFFF, and netmask is 31, the value of
an arithmetic expression 2 << (netmask - mask_bits - 1) is subject
to overflow due to a failure casting operands to a larger data type
before performing the arithmetic.

Note that it's harmless since the value will be checked at the next step.

Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Fixes: b9fed748185a ("netfilter: ipset: Check and reject crazy /0 input parameters")
Signed-off-by: Ilia.Gavrilov <Ilia.Gavrilov@infotecs.ru>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/ipset/ip_set_bitmap_ip.c