f2fs: quota: fix potential deadlock
authorChao Yu <chao@kernel.org>
Fri, 3 Sep 2021 02:38:11 +0000 (10:38 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Thu, 16 Sep 2021 15:38:32 +0000 (08:38 -0700)
commita5c0042200b28fff3bde6fa128ddeaef97990f8d
tree108af763734473da32b3eb69c9386c7cd26ba7ab
parent92d602bc7177325e7453189a22e0c8764ed3453e
f2fs: quota: fix potential deadlock

As Yi Zhuang reported in bugzilla:

https://bugzilla.kernel.org/show_bug.cgi?id=214299

There is potential deadlock during quota data flush as below:

Thread A: Thread B:
f2fs_dquot_acquire
down_read(&sbi->quota_sem)
f2fs_write_checkpoint
block_operations
f2fs_look_all
down_write(&sbi->cp_rwsem)
f2fs_quota_write
f2fs_write_begin
__do_map_lock
f2fs_lock_op
down_read(&sbi->cp_rwsem)
__need_flush_qutoa
down_write(&sbi->quota_sem)

This patch changes block_operations() to use trylock, if it fails,
it means there is potential quota data updater, in this condition,
let's flush quota data first and then trylock again to check dirty
status of quota data.

The side effect is: in heavy race condition (e.g. multi quota data
upaters vs quota data flusher), it may decrease the probability of
synchronizing quota data successfully in checkpoint() due to limited
retry time of quota flush.

Reported-by: Yi Zhuang <zhuangyi1@huawei.com>
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/checkpoint.c