scsi: sr: Fix typo in CDROM(CLOSETRAY|EJECT) handling
authorKevin Groeneveld <kgroeneveld@lenbrook.com>
Wed, 23 Mar 2022 00:22:42 +0000 (20:22 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 30 Mar 2022 03:37:45 +0000 (23:37 -0400)
commitbc5519c18a32ce855bb51b9f5eceb77a9489d080
tree8da9612a7e0fc4f98a8753b22f6134590827ccf1
parentf16aa285e6185271bc6812a176f7ae3dbd7fe28d
scsi: sr: Fix typo in CDROM(CLOSETRAY|EJECT) handling

Commit 2e27f576abc6 ("scsi: scsi_ioctl: Call scsi_cmd_ioctl() from
scsi_ioctl()") seems to have a typo as it is checking ret instead of cmd in
the if statement checking for CDROMCLOSETRAY and CDROMEJECT.  This changes
the behaviour of these ioctls as the cdrom_ioctl handling of these is more
restrictive than the scsi_ioctl version.

Link: https://lore.kernel.org/r/20220323002242.21157-1-kgroeneveld@lenbrook.com
Fixes: 2e27f576abc6 ("scsi: scsi_ioctl: Call scsi_cmd_ioctl() from scsi_ioctl()")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kevin Groeneveld <kgroeneveld@lenbrook.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sr.c