projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e463a09) | patch
bitfield.h: Fix "type of reg too small for mask" test
authorPeter Zijlstra <peterz@infradead.org>
Wed, 10 Nov 2021 10:01:03 +0000 (11:01 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Sat, 11 Dec 2021 08:09:45 +0000 (09:09 +0100)
commitbff8c3848e071d387d8b0784dc91fa49cd563774
tree15b9247051bbfac2551bcbace278c62106474395tree | snapshot
parente463a09af2f0677b9485a7e8e4e70b396b2ffb6fcommit | diff
bitfield.h: Fix "type of reg too small for mask" test

The test: 'mask > (typeof(_reg))~0ull' only works correctly when both
sides are unsigned, consider:

 - 0xff000000 vs (int)~0ull
 - 0x000000ff vs (int)~0ull

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lore.kernel.org/r/20211110101324.950210584@infradead.org
include/linux/bitfield.h diff | blob | history
ep93xx device tree rework repo: git://git.maquefel.me/linux.git