tipc: fix unexpected link reset due to discovery messages
authorTung Nguyen <tung.q.nguyen@dektech.com.au>
Thu, 5 Jan 2023 06:02:51 +0000 (06:02 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 6 Jan 2023 12:53:10 +0000 (12:53 +0000)
commitc244c092f1ed2acfb5af3d3da81e22367d3dd733
tree66b0953420eff8cd9656132c25ece576ef3c3cd6
parenteea8ce81fbb544e3caad1a1c876ba1af467b3d3c
tipc: fix unexpected link reset due to discovery messages

This unexpected behavior is observed:

node 1                    | node 2
------                    | ------
link is established       | link is established
reboot                    | link is reset
up                        | send discovery message
receive discovery message |
link is established       | link is established
send discovery message    |
                          | receive discovery message
                          | link is reset (unexpected)
                          | send reset message
link is reset             |

It is due to delayed re-discovery as described in function
tipc_node_check_dest(): "this link endpoint has already reset
and re-established contact with the peer, before receiving a
discovery message from that node."

However, commit 598411d70f85 has changed the condition for calling
tipc_node_link_down() which was the acceptance of new media address.

This commit fixes this by restoring the old and correct behavior.

Fixes: 598411d70f85 ("tipc: make resetting of links non-atomic")
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/node.c