perf/x86/intel/uncore: Fix reference count leak in sad_cfg_iio_topology()
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Fri, 18 Nov 2022 06:31:34 +0000 (14:31 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 24 Nov 2022 10:09:24 +0000 (11:09 +0100)
commitc508eb042d9739bf9473526f53303721b70e9100
treedb65bd9cd139c5d130d028c16d4480d8ce0d0136
parentd5b73506b5b1b4a6e675c54b7977ea08e64cba19
perf/x86/intel/uncore: Fix reference count leak in sad_cfg_iio_topology()

pci_get_device() will increase the reference count for the returned
pci_dev, and also decrease the reference count for the input parameter
*from* if it is not NULL.

If we break the loop in sad_cfg_iio_topology() with 'dev' not NULL. We
need to call pci_dev_put() to decrease the reference count. Since
pci_dev_put() can handle the NULL input parameter, we can just add one
pci_dev_put() right before 'return ret'.

Fixes: c1777be3646b ("perf/x86/intel/uncore: Enable I/O stacks to IIO PMON mapping on SNR")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20221118063137.121512-2-wangxiongfeng2@huawei.com
arch/x86/events/intel/uncore_snbep.c