ui/vnc-clipboard: fix infinite loop in inflate_buffer (CVE-2023-3255)
authorMauro Matteo Cascella <mcascell@redhat.com>
Tue, 4 Jul 2023 08:41:22 +0000 (10:41 +0200)
committerMarc-André Lureau <marcandre.lureau@redhat.com>
Mon, 17 Jul 2023 11:20:56 +0000 (15:20 +0400)
commitd921fea338c1059a27ce7b75309d7a2e485f710b
treef239072cd590cde62cc59fa6af1db4713a5d144f
parent9c18a9234bab9d5e903f897b30fb4a37888aebfc
ui/vnc-clipboard: fix infinite loop in inflate_buffer (CVE-2023-3255)

A wrong exit condition may lead to an infinite loop when inflating a
valid zlib buffer containing some extra bytes in the `inflate_buffer`
function. The bug only occurs post-authentication. Return the buffer
immediately if the end of the compressed data has been reached
(Z_STREAM_END).

Fixes: CVE-2023-3255
Fixes: 0bf41cab ("ui/vnc: clipboard support")
Reported-by: Kevin Denis <kevin.denis@synacktiv.com>
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Tested-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <20230704084210.101822-1-mcascell@redhat.com>
ui/vnc-clipboard.c