drm/i915: don't make assumptions about intel_wakeref_t type
authorJani Nikula <jani.nikula@intel.com>
Thu, 4 Jan 2024 16:46:00 +0000 (18:46 +0200)
committerJani Nikula <jani.nikula@intel.com>
Fri, 5 Jan 2024 11:49:43 +0000 (13:49 +0200)
commitde06b42edc5bf05aefbb7e2f59475d6022ed57e1
tree95f1adf665798cb6773a360253a4eabc2be8071c
parent835e4d9bb3a13879031942ca6692d5a82ec00158
drm/i915: don't make assumptions about intel_wakeref_t type

intel_wakeref_t is supposed to be a mostly opaque cookie to its
users. It should only be checked for being non-zero and set to
zero. Debug logging its actual value is meaningless. Switch to just
debug logging whether the async_put_wakeref is non-zero.

The issue dates back to much earlier than
commit b49e894c3fd8 ("drm/i915: Replace custom intel runtime_pm tracker
with ref_tracker library"), but this is the one that brought about a
build failure due to the printf format.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/r/20240102111222.2db11208@canb.auug.org.au
Fixes: b49e894c3fd8 ("drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library")
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240104164600.783371-1-jani.nikula@intel.com
drivers/gpu/drm/i915/display/intel_display_power.c