From 043786303b175977e515d4e99cf6b5f886b136dc Mon Sep 17 00:00:00 2001 From: Heiner Kallweit Date: Fri, 18 Feb 2022 14:58:35 +0100 Subject: [PATCH] spi: use sysfs_emit() for printing statistics and add trailing newline Use dedicated function sysfs_emit() that does some extra checking, e.g. to ensure that no more than PAGESIZE bytes are written. In addition add a trailing newline to the output, that makes it better readable from the console. Signed-off-by: Heiner Kallweit Link: https://lore.kernel.org/r/56e1588d-d53b-73e9-fdc8-7fe30bf91f11@gmail.com Signed-off-by: Mark Brown --- drivers/spi/spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 85f8ae4cc0c0d..cd4dc3131e17f 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -143,7 +143,7 @@ static ssize_t spi_statistics_##name##_show(struct spi_statistics *stat, \ unsigned long flags; \ ssize_t len; \ spin_lock_irqsave(&stat->lock, flags); \ - len = sprintf(buf, format_string, stat->field); \ + len = sysfs_emit(buf, format_string "\n", stat->field); \ spin_unlock_irqrestore(&stat->lock, flags); \ return len; \ } \ -- 2.30.2