From 06277ca23868d3e1ce9d09650f2cf14abc6b69be Mon Sep 17 00:00:00 2001 From: Ido Schimmel <idosch@nvidia.com> Date: Wed, 15 Sep 2021 13:13:09 +0300 Subject: [PATCH] mlxsw: spectrum: Do not return an error in ndo_stop() The return value is not checked by the networking stack. Allows us to simplify a later patch. Signed-off-by: Ido Schimmel <idosch@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c index 9cbc893c2545a..976d7e1ecb145 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c @@ -577,7 +577,8 @@ static int mlxsw_sp_port_stop(struct net_device *dev) struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev); netif_stop_queue(dev); - return mlxsw_sp_port_admin_status_set(mlxsw_sp_port, false); + mlxsw_sp_port_admin_status_set(mlxsw_sp_port, false); + return 0; } static netdev_tx_t mlxsw_sp_port_xmit(struct sk_buff *skb, -- 2.30.2