From 0705ecc4ade74f03df00e8528987e7876a293f3b Mon Sep 17 00:00:00 2001
From: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Date: Wed, 3 Jun 2020 16:09:00 +0800
Subject: [PATCH] monitor/hmp-cmds: delete redundant Error check before invoke
hmp_handle_error()
hmp_handle_error() does Error check internally.
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Message-Id: <20200603080904.997083-6-maozhongyi@cmss.chinamobile.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
monitor/hmp-cmds.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index a704b3469a..504796d6e9 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1637,9 +1637,8 @@ void hmp_object_add(Monitor *mon, const QDict *qdict)
obj = user_creatable_add_opts(opts, &err);
qemu_opts_del(opts);
- if (err) {
- hmp_handle_error(mon, err);
- }
+ hmp_handle_error(mon, err);
+
if (obj) {
object_unref(obj);
}
--
2.30.2