From 0c6c98e401b22fa2737bb7266742ae88722825ab Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Sun, 3 Jun 2018 23:23:48 +0300 Subject: [PATCH] tpl/strings: Remove overflow check in strings.Repeat The test fails on 32 bit systems. Let it panic instead. --- tpl/strings/strings.go | 2 -- tpl/strings/strings_test.go | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tpl/strings/strings.go b/tpl/strings/strings.go index 7bd6a9af..d7d8f2d8 100644 --- a/tpl/strings/strings.go +++ b/tpl/strings/strings.go @@ -432,8 +432,6 @@ func (ns *Namespace) Repeat(n, s interface{}) (string, error) { if sn < 0 { return "", errors.New("strings: negative Repeat count") - } else if sn > 0 && len(ss)*sn/sn != len(ss) { - return "", errors.New("strings: Repeat count causes overflow") } return _strings.Repeat(ss, sn), nil diff --git a/tpl/strings/strings_test.go b/tpl/strings/strings_test.go index 6f714702..69863c30 100644 --- a/tpl/strings/strings_test.go +++ b/tpl/strings/strings_test.go @@ -16,7 +16,6 @@ package strings import ( "fmt" "html/template" - "math" "testing" "github.com/gohugoio/hugo/deps" @@ -730,7 +729,7 @@ func TestRepeat(t *testing.T) { // errors {"", tstNoStringer{}, false}, {tstNoStringer{}, "", false}, - {"ab", math.MaxInt64, false}, + {"ab", -1, false}, } { errMsg := fmt.Sprintf("[%d] %v", i, test) -- 2.30.2