From 0d326e722d76f1e8227f92573c6b7b69025c52b4 Mon Sep 17 00:00:00 2001 From: Sergio Paracuellos Date: Sat, 21 Mar 2020 08:26:49 +0100 Subject: [PATCH] staging: mt7621-dts: gpio 8 and 9 are vendor specific There are three pins that can be used for reset gpios. As mentioned in the application note, there are two possible way of wiring pcie reset: * connect gpio19 to all pcie reset pins * connect gpio19 to pcie0 reset and pick two other gpios for pcie1 and pcie2 gpio7 and gpio8 may not be used as pcie reset and are vendor specific. Hence, maintain common mt7621.dtsi with only gpio19 which is common and make an overlay for gnubee board which uses all gpio's as resets for pcie. After this changes release gpios in driver code is not needed anymore. Signed-off-by: Sergio Paracuellos Link: https://lore.kernel.org/r/20200321072650.7784-2-sergio.paracuellos@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/mt7621-dts/gbpc1.dts | 4 ++++ drivers/staging/mt7621-dts/mt7621.dtsi | 4 +--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-dts/gbpc1.dts b/drivers/staging/mt7621-dts/gbpc1.dts index 1fb560ff059c8..a7c0d3115d726 100644 --- a/drivers/staging/mt7621-dts/gbpc1.dts +++ b/drivers/staging/mt7621-dts/gbpc1.dts @@ -114,6 +114,10 @@ &pcie { pinctrl-names = "default"; pinctrl-0 = <&pcie_pins>; + + reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>, + <&gpio 8 GPIO_ACTIVE_LOW>, + <&gpio 7 GPIO_ACTIVE_LOW>; status = "okay"; }; diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi index 10fb497cf81ad..9e5cf68731bb0 100644 --- a/drivers/staging/mt7621-dts/mt7621.dtsi +++ b/drivers/staging/mt7621-dts/mt7621.dtsi @@ -538,9 +538,7 @@ phys = <&pcie0_phy 1>, <&pcie2_phy 0>; phy-names = "pcie-phy0", "pcie-phy2"; - reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>, - <&gpio 8 GPIO_ACTIVE_LOW>, - <&gpio 7 GPIO_ACTIVE_LOW>; + reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>; pcie@0,0 { reg = <0x0000 0 0 0 0>; -- 2.30.2