From 0d34be75878093bef5055311c254ae3ff459fd8f Mon Sep 17 00:00:00 2001
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Tue, 24 Mar 2015 20:14:28 +0530
Subject: [PATCH] greybus: Greybus: Place module_init/exit() right after
respective routines
As mentioned in kernel coding guidelines.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
---
drivers/staging/greybus/gpb.c | 3 +--
drivers/staging/greybus/vibrator.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/gpb.c b/drivers/staging/greybus/gpb.c
index 931d739f9fb91..33bbe7917f095 100644
--- a/drivers/staging/greybus/gpb.c
+++ b/drivers/staging/greybus/gpb.c
@@ -72,6 +72,7 @@ error_pwm:
error_gpio:
return -EPROTO;
}
+module_init(gpbridge_init);
static void __exit gpbridge_exit(void)
{
@@ -84,8 +85,6 @@ static void __exit gpbridge_exit(void)
gb_pwm_protocol_exit();
gb_gpio_protocol_exit();
}
-
-module_init(gpbridge_init);
module_exit(gpbridge_exit);
MODULE_LICENSE("GPL");
diff --git a/drivers/staging/greybus/vibrator.c b/drivers/staging/greybus/vibrator.c
index c92c69ef30255..2943a9b381c6b 100644
--- a/drivers/staging/greybus/vibrator.c
+++ b/drivers/staging/greybus/vibrator.c
@@ -185,14 +185,13 @@ static __init int protocol_init(void)
return gb_protocol_register(&vibrator_protocol);
}
+module_init(protocol_init);
static __exit void protocol_exit(void)
{
gb_protocol_deregister(&vibrator_protocol);
class_unregister(&vibrator_class);
}
-
-module_init(protocol_init);
module_exit(protocol_exit);
MODULE_LICENSE("GPL v2");
--
2.30.2