From 141b91774935fd8fc234b091f3e6daf940782698 Mon Sep 17 00:00:00 2001 From: Esben Haabendal Date: Tue, 6 Dec 2022 09:46:37 +0100 Subject: [PATCH] gpioset: fix memory leak in interactive mode Even when readline() returns an empty buffer, we still need to free() it to avoid leaking memory. Signed-off-by: Esben Haabendal [Kent: suggested a shorter version] Co-developed-by: Kent Gibson Signed-off-by: Bartosz Golaszewski --- tools/gpioset.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/gpioset.c b/tools/gpioset.c index 698dba3..374fe72 100644 --- a/tools/gpioset.c +++ b/tools/gpioset.c @@ -768,8 +768,10 @@ static void interact(struct gpiod_line_request **requests, fflush(stdout); line = readline(PROMPT); - if (!line || line[0] == '\0') + if (!line || line[0] == '\0') { + free(line); continue; + } for (i = strlen(line) - 1; (i > 0) && isspace(line[i]); i--) line[i] = '\0'; -- 2.30.2