From 17d28aa8bdb11ba77d86a7ff228b1963afb7941d Mon Sep 17 00:00:00 2001 From: Matthew Auld Date: Wed, 9 Aug 2023 09:44:24 +0100 Subject: [PATCH] drm/xe: don't warn for bogus pagefaults This appears to be easily user triggerable so warning is perhaps too much. Rather just make it debug print. Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/534 Signed-off-by: Matthew Auld Cc: Matthew Brost Reviewed-by: Matthew Brost Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 4 ++-- drivers/gpu/drm/xe/xe_guc_submit.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c index d8ff05e25eda5..21e0e9c7b6340 100644 --- a/drivers/gpu/drm/xe/xe_gt_pagefault.c +++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c @@ -265,7 +265,7 @@ static int send_pagefault_reply(struct xe_guc *guc, static void print_pagefault(struct xe_device *xe, struct pagefault *pf) { - drm_warn(&xe->drm, "\n\tASID: %d\n" + drm_dbg(&xe->drm, "\n\tASID: %d\n" "\tVFID: %d\n" "\tPDATA: 0x%04x\n" "\tFaulted Address: 0x%08x%08x\n" @@ -370,7 +370,7 @@ static void pf_queue_work_func(struct work_struct *w) if (unlikely(ret)) { print_pagefault(xe, &pf); pf.fault_unsuccessful = 1; - drm_warn(&xe->drm, "Fault response: Unsuccessful %d\n", ret); + drm_dbg(&xe->drm, "Fault response: Unsuccessful %d\n", ret); } reply.dw0 = FIELD_PREP(PFR_VALID, 1) | diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c index 19df4b67bfbbc..b89964d6562ed 100644 --- a/drivers/gpu/drm/xe/xe_guc_submit.c +++ b/drivers/gpu/drm/xe/xe_guc_submit.c @@ -1641,7 +1641,7 @@ int xe_guc_exec_queue_memory_cat_error_handler(struct xe_guc *guc, u32 *msg, if (unlikely(!q)) return -EPROTO; - drm_warn(&xe->drm, "Engine memory cat error: guc_id=%d", guc_id); + drm_dbg(&xe->drm, "Engine memory cat error: guc_id=%d", guc_id); trace_xe_exec_queue_memory_cat_error(q); /* Treat the same as engine reset */ -- 2.30.2