From 17dcc588d42b3e24a8482c60759201f138700ec0 Mon Sep 17 00:00:00 2001 From: Geordan Neukum Date: Wed, 5 Jun 2019 01:09:13 +0000 Subject: [PATCH] staging: kpc2000: kpc_spi: remove unnecessary cast in [read|write]_reg() The kpc_spi driver unnecessarily casts from a (u64 __iomem *) to a (void *) when invoking readq and writeq which both take a (void __iomem *) arg. There is no need for this cast, and it actually harms us by discarding the sparse cookie, __iomem. Make the driver stop performing this casting operation. Signed-off-by: Geordan Neukum Signed-off-by: Greg Kroah-Hartman --- drivers/staging/kpc2000/kpc2000_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c index 4f517afc6239d..28132e9e260d0 100644 --- a/drivers/staging/kpc2000/kpc2000_spi.c +++ b/drivers/staging/kpc2000/kpc2000_spi.c @@ -167,7 +167,7 @@ kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx) if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0)){ return cs->conf_cache; } - val = readq((void*)addr); + val = readq(addr); return val; } @@ -176,7 +176,7 @@ kp_spi_write_reg(struct kp_spi_controller_state *cs, int idx, u64 val) { u64 __iomem *addr = cs->base; addr += idx; - writeq(val, (void*)addr); + writeq(val, addr); if (idx == KP_SPI_REG_CONFIG) cs->conf_cache = val; } -- 2.30.2