From 262ee3a07e98e8e56230547d4fe75d485348a55a Mon Sep 17 00:00:00 2001 From: Andreas Gruenbacher Date: Fri, 29 Mar 2024 15:46:32 +0100 Subject: [PATCH] gfs2: Get rid of unnecessary test_and_set_bit The GLF_LOCK flag is protected by the gl->gl_lockref.lock spin lock which is held when entering run_queue(), so we can use test_bit() and set_bit() here. Signed-off-by: Andreas Gruenbacher --- fs/gfs2/glock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index a700e424f7903..fa047331ea3c5 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -842,8 +842,9 @@ __acquires(&gl->gl_lockref.lock) { struct gfs2_holder *gh = NULL; - if (test_and_set_bit(GLF_LOCK, &gl->gl_flags)) + if (test_bit(GLF_LOCK, &gl->gl_flags)) return; + set_bit(GLF_LOCK, &gl->gl_flags); GLOCK_BUG_ON(gl, test_bit(GLF_DEMOTE_IN_PROGRESS, &gl->gl_flags)); -- 2.30.2