From 26311cd112d05abe8cbe87189c93fa25cc25709b Mon Sep 17 00:00:00 2001 From: Sarosh Hasan Date: Mon, 26 Feb 2024 15:12:26 +0530 Subject: [PATCH] net: stmmac: dwmac-qcom-ethqos: Update link clock rate only for RGMII Updating link clock rate for different speeds is only needed when using RGMII, as that mode requires changing clock speed when the link speed changes. Let's restrict updating the link clock speed in ethqos_update_link_clk() to just RGMII. Other modes such as SGMII only need to enable the link clock (which is already done in probe). Signed-off-by: Sarosh Hasan Reviewed-by: Andrew Lunn Reviewed-by: Andrew Halaney Tested-by: Andrew Halaney # sa8775p-ride Reviewed-by: Abhishek Chauhan Signed-off-by: David S. Miller --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 3e7aa743ca972..e254b21fdb598 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -170,6 +170,9 @@ static void rgmii_dump(void *priv) static void ethqos_update_link_clk(struct qcom_ethqos *ethqos, unsigned int speed) { + if (!phy_interface_mode_is_rgmii(ethqos->phy_mode)) + return; + switch (speed) { case SPEED_1000: ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ; -- 2.30.2