From 270e05092e09b22e083b5e2802a73b52a6b813eb Mon Sep 17 00:00:00 2001 From: Michael Straube Date: Sat, 6 Aug 2022 08:09:27 +0200 Subject: [PATCH] staging: r8188eu: use ffs() in phy_CalculateBitShift() Use ffs() in phy_CalculateBitShift() to simplify the function and improve readability. Tested-by: Philipp Hortmann # Edimax N150 Signed-off-by: Michael Straube Link: https://lore.kernel.org/r/20220806060929.11022-2-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c index dea6d915a1f40..3d8fcc1f0b6af 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c @@ -25,13 +25,9 @@ */ static u32 phy_CalculateBitShift(u32 BitMask) { - u32 i; + u32 i = ffs(BitMask); - for (i = 0; i <= 31; i++) { - if (((BitMask >> i) & 0x1) == 1) - break; - } - return i; + return i ? i - 1 : 32; } /** -- 2.30.2