From 27afa47fcbb5905ada95e1e7b8ab9faba9ba9c0c Mon Sep 17 00:00:00 2001 From: Erik Schilling Date: Thu, 28 Sep 2023 08:23:19 +0200 Subject: [PATCH] bindings: rust: remove useless clone Reported by 1.74.0-nightly: warning: call to `.clone()` on a reference in this situation does nothing --> libgpiod/tests/line_request.rs:71:44 | 71 | let chip_name = sim.chip_name().clone(); | ^^^^^^^^ help: remove this redundant call | = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed = note: `#[warn(noop_method_call)]` on by default Signed-off-by: Erik Schilling Acked-by: Viresh Kumar Signed-off-by: Bartosz Golaszewski --- bindings/rust/libgpiod/tests/line_request.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bindings/rust/libgpiod/tests/line_request.rs b/bindings/rust/libgpiod/tests/line_request.rs index 9af5226..da22bea 100644 --- a/bindings/rust/libgpiod/tests/line_request.rs +++ b/bindings/rust/libgpiod/tests/line_request.rs @@ -68,7 +68,7 @@ mod line_request { let arc = config.sim(); let sim = arc.lock().unwrap(); - let chip_name = sim.chip_name().clone(); + let chip_name = sim.chip_name(); assert_eq!(config.request().chip_name().unwrap(), chip_name); } -- 2.30.2