From 28502e02e27ab45ba948bec970be95dc771a5175 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Pouiller?= Date: Mon, 20 Apr 2020 18:03:04 +0200 Subject: [PATCH] staging: wfx: drop useless update of field basic_rate_set MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Basic Rates are already set by hif_join(). hif_join() is also able to manage possible changes after association. Firmware also allows to change the Basic Rates with hif_set_association_mode() but it does not bring anything in our case. Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20200420160311.57323-10-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wfx/hif_tx_mib.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wfx/hif_tx_mib.c b/drivers/staging/wfx/hif_tx_mib.c index f04116ecb3730..16f4908055afa 100644 --- a/drivers/staging/wfx/hif_tx_mib.c +++ b/drivers/staging/wfx/hif_tx_mib.c @@ -190,15 +190,12 @@ int hif_set_block_ack_policy(struct wfx_vif *wvif, int hif_set_association_mode(struct wfx_vif *wvif, struct ieee80211_bss_conf *info) { - int basic_rates = wfx_rate_mask_to_hw(wvif->wdev, info->basic_rates); struct ieee80211_sta *sta = NULL; struct hif_mib_set_association_mode val = { .preambtype_use = 1, .mode = 1, - .rateset = 1, .spacing = 1, .short_preamble = info->use_short_preamble, - .basic_rate_set = cpu_to_le32(basic_rates) }; rcu_read_lock(); // protect sta -- 2.30.2