From 2b92c3946ea7b223c3a418f3f423bd1711f723f7 Mon Sep 17 00:00:00 2001 From: Marcelo Aloisio da Silva Date: Fri, 18 Feb 2022 01:01:40 -0300 Subject: [PATCH] staging: r8188eu: move out assignment in if condition Should not use assignment in if condition. Signed-off-by: Marcelo Aloisio da Silva Link: https://lore.kernel.org/r/20220218040140.GA22796@snoopy Signed-off-by: Greg Kroah-Hartman --- drivers/staging/r8188eu/core/rtw_cmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c index 46a49f30f9001..6eca30124ee8a 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -1318,7 +1318,8 @@ static void c2h_wk_callback(struct work_struct *work) evtpriv->c2h_wk_alive = true; while (!rtw_cbuf_empty(evtpriv->c2h_queue)) { - if ((c2h_evt = (struct c2h_evt_hdr *)rtw_cbuf_pop(evtpriv->c2h_queue)) != NULL) { + c2h_evt = (struct c2h_evt_hdr *)rtw_cbuf_pop(evtpriv->c2h_queue); + if (c2h_evt) { /* This C2H event is read, clear it */ rtw_write8(adapter, REG_C2HEVT_CLEAR, C2H_EVT_HOST_CLOSE); } else { -- 2.30.2