From 31b17c3aeb5e9413ed627626f6213b3e53b20c8e Mon Sep 17 00:00:00 2001 From: Don Brace Date: Thu, 10 Feb 2022 14:11:51 -0600 Subject: [PATCH] scsi: smartpqi: Fix unused variable pqi_pm_ops for clang Driver added a new dev_pm_ops structure used only if CONFIG_PM is set. The CONFIG_PM MACRO needed to be moved up in the code to avoid the compiler warnings. The hunk to move the location was missing from the above patch. Found by kernel test robot by building driver with CONFIG_PM disabled. Link: https://lore.kernel.org/all/202202090657.bstNLuce-lkp@intel.com/ Link: https://lore.kernel.org/r/20220210201151.236170-1-don.brace@microchip.com Fixes: c66e078ad89e ("scsi: smartpqi: Fix hibernate and suspend") Reported-by: kernel test robot Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Reviewed-by: Mike Mcgowen Reviewed-by: Kevin Barnett Signed-off-by: Don Brace Signed-off-by: Martin K. Petersen --- drivers/scsi/smartpqi/smartpqi_init.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 61366642ea958..4611912ae2610 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -8951,6 +8951,8 @@ static void pqi_process_module_params(void) pqi_process_lockup_action_param(); } +#if defined(CONFIG_PM) + static inline enum bmic_flush_cache_shutdown_event pqi_get_flush_cache_shutdown_event(struct pci_dev *pci_dev) { if (pci_dev->subsystem_vendor == PCI_VENDOR_ID_ADAPTEC2 && pci_dev->subsystem_device == 0x1304) @@ -9073,6 +9075,8 @@ static const struct dev_pm_ops pqi_pm_ops = { .restore = pqi_resume_or_restore, }; +#endif /* CONFIG_PM */ + /* Define the PCI IDs for the controllers that we support. */ static const struct pci_device_id pqi_pci_id_table[] = { { -- 2.30.2