From 31d4c1bdf157421b26d51f61a4da95dd20d171e2 Mon Sep 17 00:00:00 2001 From: David Jander Date: Wed, 29 Jun 2022 16:25:19 +0200 Subject: [PATCH] spi: spi.c: Remove redundant else block Reported-by: Andy Shevchenko Signed-off-by: David Jander Link: https://lore.kernel.org/r/20220629142519.3985486-4-david@protonic.nl Signed-off-by: Mark Brown --- drivers/spi/spi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 6d69f5dc62bcf..ebc47f63239fb 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1636,13 +1636,13 @@ static int __spi_pump_transfer_message(struct spi_controller *ctlr, dev_err(&ctlr->dev, "failed to transfer one message from queue\n"); return ret; - } else { - WRITE_ONCE(ctlr->cur_msg_need_completion, true); - smp_mb(); /* see spi_finalize_current_message()... */ - if (READ_ONCE(ctlr->cur_msg_incomplete)) - wait_for_completion(&ctlr->cur_msg_completion); } + WRITE_ONCE(ctlr->cur_msg_need_completion, true); + smp_mb(); /* See spi_finalize_current_message()... */ + if (READ_ONCE(ctlr->cur_msg_incomplete)) + wait_for_completion(&ctlr->cur_msg_completion); + return 0; } -- 2.30.2