From 4437590d5f1a44078d54c0b959f38e22a8703fc7 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Thu, 20 Jul 2023 22:47:59 -0400 Subject: [PATCH] bcachefs: Fix btree iter leak in __bch2_insert_snapshot_whiteouts() Signed-off-by: Kent Overstreet --- fs/bcachefs/btree_update_leaf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/bcachefs/btree_update_leaf.c b/fs/bcachefs/btree_update_leaf.c index 336a91e4fb204..947c28b76ff0f 100644 --- a/fs/bcachefs/btree_update_leaf.c +++ b/fs/bcachefs/btree_update_leaf.c @@ -1327,7 +1327,7 @@ int __bch2_insert_snapshot_whiteouts(struct btree_trans *trans, struct bpos new_pos) { struct bch_fs *c = trans->c; - struct btree_iter old_iter, new_iter; + struct btree_iter old_iter, new_iter = { NULL }; struct bkey_s_c old_k, new_k; snapshot_id_list s; struct bkey_i *update; @@ -1377,6 +1377,7 @@ int __bch2_insert_snapshot_whiteouts(struct btree_trans *trans, if (ret) break; } + bch2_trans_iter_exit(trans, &new_iter); bch2_trans_iter_exit(trans, &old_iter); darray_exit(&s); -- 2.30.2