From 4d883eeac4e3c2b89a32d64b1b1a25e8c60f5537 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Tue, 29 May 2018 16:29:37 +0200 Subject: [PATCH] staging: unisys: visornic: no need to check debugfs return values When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Clean up the visornic driver code by not caring about the value of debugfs calls. This ends up removing a number of lines of code that are not needed. Cc: David Kershner Cc: Tim Sell Cc: David Binder Cc: Sameer Wadgaonkar Cc: Charles Daniels Cc: sparmaintainer@unisys.com Signed-off-by: Greg Kroah-Hartman --- .../staging/unisys/visornic/visornic_main.c | 23 +++++-------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c index f734e835b3829..3647b8f1ed286 100644 --- a/drivers/staging/unisys/visornic/visornic_main.c +++ b/drivers/staging/unisys/visornic/visornic_main.c @@ -2126,30 +2126,19 @@ static struct visor_driver visornic_driver = { */ static int visornic_init(void) { - struct dentry *ret; - int err = -ENOMEM; + int err; visornic_debugfs_dir = debugfs_create_dir("visornic", NULL); - if (!visornic_debugfs_dir) - return err; - ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL, - &debugfs_info_fops); - if (!ret) - goto cleanup_debugfs; - ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir, - NULL, &debugfs_enable_ints_fops); - if (!ret) - goto cleanup_debugfs; + debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL, + &debugfs_info_fops); + debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir, NULL, + &debugfs_enable_ints_fops); err = visorbus_register_visor_driver(&visornic_driver); if (err) - goto cleanup_debugfs; + debugfs_remove_recursive(visornic_debugfs_dir); - return 0; - -cleanup_debugfs: - debugfs_remove_recursive(visornic_debugfs_dir); return err; } -- 2.30.2