From 521b80676927df6b4ad4fc87b7756aad43b96d12 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Wed, 20 Oct 2021 20:50:07 -0400 Subject: [PATCH] bcachefs: Delete dentry when deleting snapshots This fixes a bug where subsequently doing creates with the same name fails. Signed-off-by: Kent Overstreet --- fs/bcachefs/fs-ioctl.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c index ae402d350d4c8..a12b591ec9caa 100644 --- a/fs/bcachefs/fs-ioctl.c +++ b/fs/bcachefs/fs-ioctl.c @@ -422,6 +422,7 @@ static long bch2_ioctl_subvolume_destroy(struct bch_fs *c, struct file *filp, struct bch_ioctl_subvolume arg) { struct path path; + struct inode *dir; int ret = 0; if (arg.flags) @@ -438,7 +439,13 @@ static long bch2_ioctl_subvolume_destroy(struct bch_fs *c, struct file *filp, return -EXDEV; } - ret = __bch2_unlink(path.dentry->d_parent->d_inode, path.dentry, 1); + dir = path.dentry->d_parent->d_inode; + + ret = __bch2_unlink(dir, path.dentry, 1); + if (!ret) { + fsnotify_rmdir(dir, path.dentry); + d_delete(path.dentry); + } path_put(&path); return ret; -- 2.30.2