From 5bd73286d50fc242bbff1aaddb0e97c4527c9d78 Mon Sep 17 00:00:00 2001 From: Al Viro <viro@zeniv.linux.org.uk> Date: Sun, 5 Apr 2020 21:59:55 -0400 Subject: [PATCH] fix a braino in legitimize_path() brown paperbag time... wrong order of arguments ended up confusing the values to check dentry and mount_lock seqcounts against. Reported-by: kernel test robot <rong.a.chen@intel.com> Fixes: 2aa38470853a ("non-RCU analogue of the previous commit") Tested-by: kernel test robot <rong.a.chen@intel.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/namei.c b/fs/namei.c index 61fdb77a7d58a..a320371899cf9 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -610,7 +610,7 @@ static bool __legitimize_path(struct path *path, unsigned seq, unsigned mseq) static inline bool legitimize_path(struct nameidata *nd, struct path *path, unsigned seq) { - return __legitimize_path(path, nd->m_seq, seq); + return __legitimize_path(path, seq, nd->m_seq); } static bool legitimize_links(struct nameidata *nd) -- 2.30.2