From 626af58bad5817af442d992f9966a7bf793f1562 Mon Sep 17 00:00:00 2001 From: Peng Wu Date: Tue, 28 Jun 2022 13:09:20 +0000 Subject: [PATCH] net: dsa: rzn1-a5psw: fix a NULL vs IS_ERR() check in a5psw_probe() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The devm_platform_ioremap_resource() function never returns NULL. It returns error pointers. Signed-off-by: Peng Wu Reported-by: Hulk Robot Reviewed-by: Clément Léger Link: https://lore.kernel.org/r/20220628130920.49493-1-wupeng58@huawei.com Signed-off-by: Jakub Kicinski --- drivers/net/dsa/rzn1_a5psw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c index 3e910da98ae24..5b14e2ba9b79a 100644 --- a/drivers/net/dsa/rzn1_a5psw.c +++ b/drivers/net/dsa/rzn1_a5psw.c @@ -946,8 +946,8 @@ static int a5psw_probe(struct platform_device *pdev) mutex_init(&a5psw->lk_lock); spin_lock_init(&a5psw->reg_lock); a5psw->base = devm_platform_ioremap_resource(pdev, 0); - if (!a5psw->base) - return -EINVAL; + if (IS_ERR(a5psw->base)) + return PTR_ERR(a5psw->base); ret = a5psw_pcs_get(a5psw); if (ret) -- 2.30.2