From 7274ce0558adb4b9b1f5c5b613fb4fe331c18911 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Mon, 23 May 2022 10:38:13 +0200 Subject: [PATCH] scsi: sd: Don't call blk_cleanup_disk() in sd_probe() In SCSI the midlayer has ownership of the request_queue, so on probe failure we must only put the gendisk, but leave the request_queue alone. Link: https://lore.kernel.org/r/20220523083813.227935-1-hch@lst.de Fixes: 03252259e18e ("scsi: sd: Clean up gendisk if device_add_disk() failed") Signed-off-by: Christoph Hellwig Signed-off-by: Martin K. Petersen --- drivers/scsi/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index c583301ff4ecf..a8f61b6ea479a 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3523,7 +3523,7 @@ static int sd_probe(struct device *dev) error = device_add_disk(dev, gd, NULL); if (error) { put_device(&sdkp->disk_dev); - blk_cleanup_disk(gd); + put_disk(gd); goto out; } -- 2.30.2