From 72b384f4a7d1d120a2591fc2019cec6ae50d7998 Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Tue, 15 Aug 2017 15:30:18 +0100 Subject: [PATCH] mmio-interface: Mark as not user creatable The mmio-interface device is not something we want to allow users to create on the command line: * it is intended as an implementation detail of the memory subsystem, which gets created and deleted by that subsystem on demand; it makes no sense to create it by hand on the command line * it uses a pointer property 'host_ptr' which can't be set on the command line Mark the device as not user_creatable to avoid confusion. Signed-off-by: Peter Maydell Message-id: 1502807418-9994-1-git-send-email-peter.maydell@linaro.org Reviewed-by: Thomas Huth --- hw/misc/mmio_interface.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c index da154e5c95..894e9801cb 100644 --- a/hw/misc/mmio_interface.c +++ b/hw/misc/mmio_interface.c @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data) dc->realize = mmio_interface_realize; dc->unrealize = mmio_interface_unrealize; dc->props = mmio_interface_properties; + /* Reason: pointer property "host_ptr", and this device + * is an implementation detail of the memory subsystem, + * not intended to be created directly by the user. + */ + dc->user_creatable = false; } static const TypeInfo mmio_interface_info = { -- 2.30.2