From 78d17ecffcf41e3117a6c0408d186b99c555de76 Mon Sep 17 00:00:00 2001 From: Shahar Avidar Date: Fri, 5 Apr 2024 10:39:59 +0300 Subject: [PATCH] staging: pi433: Add debugfs_remove in case of driver register fails. debugfs resources were never cleaned in case of failure to register driver. Reported-by Dan Carpenter Fixes: 4ef027d5a367 ("staging: pi433: add debugfs interface") Signed-off-by: Shahar Avidar Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240405074000.3481217-7-ikobh7@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/pi433/pi433_if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 8aa6659936e8c..633daf50a4016 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1413,6 +1413,7 @@ static int __init pi433_init(void) return 0; unreg_class_and_remove_dbfs: + debugfs_remove(root_dir); class_unregister(&pi433_class); unreg_chrdev: unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name); -- 2.30.2