From 78ed9354c57f31000e88783496fc84dce7c8021c Mon Sep 17 00:00:00 2001 From: Guoqing Jiang Date: Sun, 18 Sep 2022 19:52:19 +0800 Subject: [PATCH] ext4: remove redundant checking in ext4_ioctl_checkpoint It is already checked after comment "check for invalid bits set", so let's remove this one. Signed-off-by: Guoqing Jiang Link: https://lore.kernel.org/r/20220918115219.12407-1-guoqing.jiang@linux.dev Signed-off-by: Theodore Ts'o --- fs/ext4/ioctl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index ad3a294a88eb2..4d49c5cfb690f 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -1063,9 +1063,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg) if (!EXT4_SB(sb)->s_journal) return -ENODEV; - if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID) - return -EINVAL; - if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) && !bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev)) return -EOPNOTSUPP; -- 2.30.2