From 7e23c1746b027ea6075816280a4e463a9399d9da Mon Sep 17 00:00:00 2001 From: Hongbo Li Date: Fri, 1 Mar 2024 11:17:45 +0800 Subject: [PATCH] bcachefs: avoid returning private error code in bch2_xattr_bcachefs_set Avoid the private error code return to caller. The error code should be transformed into genernal error code. Signed-off-by: Hongbo Li Signed-off-by: Kent Overstreet --- fs/bcachefs/xattr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/bcachefs/xattr.c b/fs/bcachefs/xattr.c index 9c0d2316031b1..754f17bba68ed 100644 --- a/fs/bcachefs/xattr.c +++ b/fs/bcachefs/xattr.c @@ -544,11 +544,11 @@ static int bch2_xattr_bcachefs_set(const struct xattr_handler *handler, kfree(buf); if (ret < 0) - return ret; + goto err_class_exit; ret = bch2_opt_check_may_set(c, opt_id, v); if (ret < 0) - return ret; + goto err_class_exit; s.v = v + 1; s.defined = true; @@ -595,6 +595,7 @@ err: (opt_id == Opt_compression && !inode_opt_get(c, &inode->ei_inode, background_compression)))) bch2_set_rebalance_needs_scan(c, inode->ei_inode.bi_inum); +err_class_exit: return bch2_err_class(ret); } -- 2.30.2