From 815f3eeea9748213eb565395b2df5953969b18b1 Mon Sep 17 00:00:00 2001 From: Sven Schnelle Date: Tue, 29 Nov 2022 12:11:05 +0100 Subject: [PATCH] s390/tty3270: use switch/case in tty3270_erase_line() This makes the code easier to read. Signed-off-by: Sven Schnelle Acked-by: Heiko Carstens Tested-by: Niklas Schnelle Signed-off-by: Heiko Carstens --- drivers/s390/char/con3270.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c index 2ccfe14765e6f..90671dd62cb36 100644 --- a/drivers/s390/char/con3270.c +++ b/drivers/s390/char/con3270.c @@ -1306,9 +1306,11 @@ static void tty3270_erase_line(struct tty3270 *tp, int mode) int i; line = tp->screen + tp->cy; - if (mode == 0) + switch (mode) { + case 0: line->len = tp->cx; - else if (mode == 1) { + break; + case 1: for (i = 0; i < tp->cx; i++) { cell = line->cells + i; cell->character = ' '; @@ -1317,8 +1319,13 @@ static void tty3270_erase_line(struct tty3270 *tp, int mode) } if (line->len <= tp->cx) line->len = tp->cx + 1; - } else if (mode == 2) + break; + case 2: line->len = 0; + break; + default: + return; + } tty3270_convert_line(tp, tp->cy); } -- 2.30.2