From 8a8380fff3cbd8138a4e09b4d47a8717f14463a5 Mon Sep 17 00:00:00 2001 From: Martin Kaiser Date: Sun, 11 Sep 2022 16:51:22 +0200 Subject: [PATCH] staging: r8188eu: update status before link blinking Always update the status variables in rtw_led_control when we start link blinking. The if statements are not necessary. Tested-by: Philipp Hortmann # Edimax N150 Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20220911145122.15444-10-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- drivers/staging/r8188eu/core/rtw_led.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c index 0881c81f4c74c..98eebe3e41198 100644 --- a/drivers/staging/r8188eu/core/rtw_led.c +++ b/drivers/staging/r8188eu/core/rtw_led.c @@ -244,13 +244,11 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction) return; cancel_delayed_work(&pLed->blink_work); - if (pLed->bLedNoLinkBlinkInProgress) - pLed->bLedNoLinkBlinkInProgress = false; - - if (pLed->bLedBlinkInProgress) - pLed->bLedBlinkInProgress = false; + pLed->bLedNoLinkBlinkInProgress = false; + pLed->bLedBlinkInProgress = false; pLed->bLedLinkBlinkInProgress = true; + pLed->CurrLedState = LED_BLINK_NORMAL; if (pLed->bLedOn) pLed->BlinkingLedState = RTW_LED_OFF; -- 2.30.2