From 8e3ca35d122a4f8a2636b8bb07fec93443895a4d Mon Sep 17 00:00:00 2001 From: Bartosz Golaszewski Date: Sun, 19 Feb 2023 21:39:03 +0100 Subject: [PATCH] tests: fix a potential assert() abort() If info is NULL in one of the line-info test cases, we'll still try to read its property leading to an abort() triggered from assert(info). Just bail out of the test function if gpiod_chip_get_line_info() fails. Signed-off-by: Bartosz Golaszewski --- tests/tests-line-info.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/tests-line-info.c b/tests/tests-line-info.c index 137084e..75b38f0 100644 --- a/tests/tests-line-info.c +++ b/tests/tests-line-info.c @@ -19,8 +19,7 @@ GPIOD_TEST_CASE(get_line_info_good) chip = gpiod_test_open_chip_or_fail(g_gpiosim_chip_get_dev_path(sim)); - info = gpiod_chip_get_line_info(chip, 3); - g_assert_nonnull(info); + info = gpiod_test_get_line_info_or_fail(chip, 3); g_assert_cmpuint(gpiod_line_info_get_offset(info), ==, 3); } -- 2.30.2