From 9d6f1b73f83a02fb28438fa9a487f5c7d245e4af Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Wed, 3 Oct 2012 18:40:01 -0300 Subject: [PATCH] qemu-ga: ga_open_pidfile(): add new line to pidfile FHS requires that pid files should end with a new line. Also change to snprintf() while there. Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qemu-ga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-ga.c b/qemu-ga.c index daeaea5461..9b59a52461 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -255,7 +255,7 @@ static bool ga_open_pidfile(const char *pidfile) g_critical("Failed to truncate pid file"); goto fail; } - sprintf(pidstr, "%d", getpid()); + snprintf(pidstr, sizeof(pidstr), "%d\n", getpid()); if (write(pidfd, pidstr, strlen(pidstr)) != strlen(pidstr)) { g_critical("Failed to write pid file"); goto fail; -- 2.30.2