From a97fe9654287da050d5ac1cdeab825e845f4c7bb Mon Sep 17 00:00:00 2001 From: Erik Schilling Date: Wed, 27 Sep 2023 11:25:23 +0200 Subject: [PATCH] bindings: rust: construct chip infos by reference No need to clone the Arc for this. A simple reference is enough to get to the underlying chip pointer. Signed-off-by: Erik Schilling Acked-by: Viresh Kumar Signed-off-by: Bartosz Golaszewski --- bindings/rust/libgpiod/src/chip.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bindings/rust/libgpiod/src/chip.rs b/bindings/rust/libgpiod/src/chip.rs index 81e1be6..4545ddb 100644 --- a/bindings/rust/libgpiod/src/chip.rs +++ b/bindings/rust/libgpiod/src/chip.rs @@ -79,7 +79,7 @@ impl Chip { /// Get the chip name as represented in the kernel. pub fn info(&self) -> Result { - Info::new(self.ichip.clone()) + Info::new(self) } /// Get the path used to find the chip. @@ -239,9 +239,9 @@ pub struct Info { impl Info { /// Find a GPIO chip by path. - fn new(chip: Arc) -> Result { - // SAFETY: `gpiod_chip` is guaranteed to be valid here. - let info = unsafe { gpiod::gpiod_chip_get_info(chip.chip) }; + fn new(chip: &Chip) -> Result { + // SAFETY: `chip.ichip.chip` is guaranteed to be valid here. + let info = unsafe { gpiod::gpiod_chip_get_info(chip.ichip.chip) }; if info.is_null() { return Err(Error::OperationFailed( OperationType::ChipGetInfo, -- 2.30.2