From ab44d7bdeebe316a03f37c08c1f66c13ea9aa5d5 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Fri, 22 Oct 2021 17:33:38 -0400 Subject: [PATCH] bcachefs: Fix a transaction path overflow readdir() in a directory with many subvolumes could overflow transaction paths - this is a simple hack around the issue. Signed-off-by: Kent Overstreet --- fs/bcachefs/dirent.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/fs/bcachefs/dirent.c b/fs/bcachefs/dirent.c index 2ab9cbaf71f2f..6be3ec4ec4a63 100644 --- a/fs/bcachefs/dirent.c +++ b/fs/bcachefs/dirent.c @@ -529,6 +529,15 @@ retry: vfs_d_type(dirent.v->d_type))) break; ctx->pos = dirent.k->p.offset + 1; + + /* + * read_target looks up subvolumes, we can overflow paths if the + * directory has many subvolumes in it + */ + if (hweight64(trans.paths_allocated) > BTREE_ITER_MAX / 2) { + ret = -EINTR; + break; + } } bch2_trans_iter_exit(&trans, &iter); err: -- 2.30.2