From ae12cf6bf9048f037f61cd8bb85be60edfe254d7 Mon Sep 17 00:00:00 2001 From: Guenter Roeck Date: Fri, 14 May 2021 09:55:57 -0700 Subject: [PATCH] staging: rtl8188eu: Drop unnecessary NULL check after container_of The result of container_of() operations is never NULL unless the extracted element is the first element of the embedded structure. This is not the case here. The NULL check is therefore unnecessary and misleading. Remove it. This change was made automatically with the following Coccinelle script. @@ type t; identifier v; statement s; @@ <+... ( t v = container_of(...); | v = container_of(...); ) ... when != v - if (\( !v \| v == NULL \) ) s ...+> Signed-off-by: Guenter Roeck Link: https://lore.kernel.org/r/20210514165557.1384106-1-linux@roeck-us.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c index fc991c8c16d21..b4d81d3a856ce 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c @@ -4038,9 +4038,6 @@ void free_mlme_ext_priv(struct mlme_ext_priv *pmlmeext) { struct adapter *padapter = container_of(pmlmeext, struct adapter, mlmeextpriv); - if (!padapter) - return; - if (padapter->bDriverStopped) { del_timer_sync(&pmlmeext->survey_timer); del_timer_sync(&pmlmeext->link_timer); -- 2.30.2