From b4339bb9a4f807f0acfbcc89e7abe77f431058c8 Mon Sep 17 00:00:00 2001 From: Alex Deucher Date: Mon, 30 Nov 2020 17:53:43 -0500 Subject: [PATCH] drm/amdgpu/swsmu/vangogh: return error if fetching metrics fails rather than just dropping the error. Also fixes a set but not used variable warning. Reviewed-by: Evan Quan Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c index 1c1af7483dfe3..86a1410631fb3 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c @@ -410,6 +410,8 @@ static int vangogh_get_current_activity_percent(struct smu_context *smu, ret = vangogh_get_smu_metrics_data(smu, METRICS_AVERAGE_GFXACTIVITY, value); + if (ret) + return ret; break; default: dev_err(smu->adev->dev, "Invalid sensor for retrieving clock activity\n"); -- 2.30.2