From b904aada8033749558e3aaeb574a2200bf0458f0 Mon Sep 17 00:00:00 2001 From: Parav Pandit Date: Fri, 8 Feb 2019 15:15:00 -0600 Subject: [PATCH] devlink: Add WARN_ON to catch errors of not cleaning devlink objects Add WARN_ON to make sure that all sub objects of a devlink device are cleanedup before freeing the devlink device. This helps to catch any driver bugs. Signed-off-by: Parav Pandit Signed-off-by: David S. Miller --- net/core/devlink.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/core/devlink.c b/net/core/devlink.c index e6a015b8ac9bc..0de1edb65c249 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5241,6 +5241,14 @@ EXPORT_SYMBOL_GPL(devlink_unregister); */ void devlink_free(struct devlink *devlink) { + WARN_ON(!list_empty(&devlink->reporter_list)); + WARN_ON(!list_empty(&devlink->region_list)); + WARN_ON(!list_empty(&devlink->param_list)); + WARN_ON(!list_empty(&devlink->resource_list)); + WARN_ON(!list_empty(&devlink->dpipe_table_list)); + WARN_ON(!list_empty(&devlink->sb_list)); + WARN_ON(!list_empty(&devlink->port_list)); + kfree(devlink); } EXPORT_SYMBOL_GPL(devlink_free); -- 2.30.2