From bc44a73e17374d23b84ad3021bb3ed5f126eac23 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Tue, 14 Mar 2017 10:53:52 +0300 Subject: [PATCH] Staging: atomisp: kfreeing a devm allocated pointer We shouldn't pass devm allocated pointers to kfree() or it leads to a double free. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c | 1 - drivers/staging/media/atomisp/i2c/imx/otp_e2prom.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c b/drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c index 242e934a60308..b11f90c5960cf 100644 --- a/drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c +++ b/drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c @@ -69,7 +69,6 @@ void *brcc064_otp_read(struct v4l2_subdev *sd, u8 dev_addr, r = i2c_transfer(client->adapter, msg, ARRAY_SIZE(msg)); if (r != ARRAY_SIZE(msg)) { - kfree(buffer); dev_err(&client->dev, "read failed at 0x%03x\n", addr); return NULL; } diff --git a/drivers/staging/media/atomisp/i2c/imx/otp_e2prom.c b/drivers/staging/media/atomisp/i2c/imx/otp_e2prom.c index ce4e7ab7781c6..73d041f978110 100644 --- a/drivers/staging/media/atomisp/i2c/imx/otp_e2prom.c +++ b/drivers/staging/media/atomisp/i2c/imx/otp_e2prom.c @@ -79,7 +79,6 @@ void *e2prom_otp_read(struct v4l2_subdev *sd, u8 dev_addr, r = i2c_transfer(client->adapter, msg, ARRAY_SIZE(msg)); if (r != ARRAY_SIZE(msg)) { - kfree(buffer); dev_err(&client->dev, "read failed at 0x%03x\n", addr); return NULL; } -- 2.30.2