From c34a917aeff44fb5b2afeef7f5e946e4de405d5a Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Wed, 1 Jul 2020 18:53:41 +0200 Subject: [PATCH] USB: serial: kobil_sct: log failure to update line settings Log failure to update the line settings in set_termios(). This also avoids a W=1 (-Wunused-but-set-variable) warning. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold --- drivers/usb/serial/kobil_sct.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c index e9882ba209330..79ce0219fdde0 100644 --- a/drivers/usb/serial/kobil_sct.c +++ b/drivers/usb/serial/kobil_sct.c @@ -526,6 +526,10 @@ static void kobil_set_termios(struct tty_struct *tty, 0, KOBIL_TIMEOUT ); + if (result) { + dev_err(&port->dev, "failed to update line settings: %d\n", + result); + } } static int kobil_ioctl(struct tty_struct *tty, -- 2.30.2