From cba37d81f5c34197e815bcd60f075be232ae6783 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Thu, 24 Aug 2023 17:07:50 -0400 Subject: [PATCH] bcachefs: Kill stripe check in bch2_alloc_v4_invalid() Since we set bucket data type to BCH_DATA_stripe based on the data pointer, not just the stripe pointer, it doesn't make sense to check for no stripe in the .key_invalid method - this is a situation that shouldn't happen, but our other fsck/repair code handles it. Signed-off-by: Kent Overstreet --- fs/bcachefs/alloc_background.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c index ad82fbddcbf83..e36426b52a4a4 100644 --- a/fs/bcachefs/alloc_background.c +++ b/fs/bcachefs/alloc_background.c @@ -296,11 +296,6 @@ int bch2_alloc_v4_invalid(const struct bch_fs *c, struct bkey_s_c k, } break; case BCH_DATA_stripe: - if (!a.v->stripe) { - prt_printf(err, "data_type %s but stripe==0", - bch2_data_types[a.v->data_type]); - return -BCH_ERR_invalid_bkey; - } break; } -- 2.30.2