From d0110443cf4a15267322f84210007943f5b01ae0 Mon Sep 17 00:00:00 2001 From: Bragatheswaran Manickavel Date: Tue, 24 Oct 2023 23:50:51 +0530 Subject: [PATCH] amd/pds_core: core: No need for Null pointer check before kfree kfree()/vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree(). Issue reported by ifnullfree.cocci Coccinelle semantic patch script. Signed-off-by: Bragatheswaran Manickavel Reviewed-by: Shannon Nelson Reviewed-by: Wojciech Drewek Signed-off-by: David S. Miller --- drivers/net/ethernet/amd/pds_core/core.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/amd/pds_core/core.c b/drivers/net/ethernet/amd/pds_core/core.c index 2a8643e167e16..0d2091e9eb283 100644 --- a/drivers/net/ethernet/amd/pds_core/core.c +++ b/drivers/net/ethernet/amd/pds_core/core.c @@ -152,11 +152,8 @@ void pdsc_qcq_free(struct pdsc *pdsc, struct pdsc_qcq *qcq) dma_free_coherent(dev, qcq->cq_size, qcq->cq_base, qcq->cq_base_pa); - if (qcq->cq.info) - vfree(qcq->cq.info); - - if (qcq->q.info) - vfree(qcq->q.info); + vfree(qcq->cq.info); + vfree(qcq->q.info); memset(qcq, 0, sizeof(*qcq)); } -- 2.30.2