From d65a8551c822030e1214bcffbcb181d4878414b5 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Fri, 4 Oct 2019 14:38:41 -0400 Subject: [PATCH] bcachefs: Fix deref of error pointer Signed-off-by: Kent Overstreet --- fs/bcachefs/str_hash.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/bcachefs/str_hash.h b/fs/bcachefs/str_hash.h index 31e55acbbeadc..a81fc3596fc10 100644 --- a/fs/bcachefs/str_hash.h +++ b/fs/bcachefs/str_hash.h @@ -251,9 +251,10 @@ int bch2_hash_set(struct btree_trans *trans, if (!ret) ret = -ENOSPC; out: - if (slot) + if (!IS_ERR_OR_NULL(slot)) bch2_trans_iter_put(trans, slot); - bch2_trans_iter_put(trans, iter); + if (!IS_ERR_OR_NULL(iter)) + bch2_trans_iter_put(trans, iter); return ret; found: -- 2.30.2