From d8731500721d5ae26819de36c63921f4baaafe00 Mon Sep 17 00:00:00 2001 From: Matthew Auld Date: Thu, 12 Jan 2023 16:34:09 +0000 Subject: [PATCH] drm/xe/pcode: fix pcode error check On DG2 we are now getting: [ 104.456607] xe 0000:03:00.0: [drm] *ERROR* PCODE timeout, retrying with preemption disabled Looks like we just need to invert the error check for xe_pcode_try_request(), which returns zero on success. Signed-off-by: Matthew Auld Reviewed-by: Matthew Brost Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_pcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c index 39712e8437283..1a76fe4788536 100644 --- a/drivers/gpu/drm/xe/xe_pcode.c +++ b/drivers/gpu/drm/xe/xe_pcode.c @@ -155,7 +155,7 @@ int xe_pcode_request(struct xe_gt *gt, u32 mbox, u32 request, ret = xe_pcode_try_request(gt, mbox, request, reply_mask, reply, &status, false, timeout_base_ms * 1000); - if (ret) + if (!ret) goto out; /* -- 2.30.2